Skip to content

docs: Extend contributing section #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024
Merged

docs: Extend contributing section #895

merged 1 commit into from
Feb 21, 2024

Conversation

Hofer-Julian
Copy link
Contributor

libxmljs one of our nodejs dependencies requires a C++ compiler

`libxmljs` one of our nodejs dependencies requires a C++ compiler
@Hofer-Julian Hofer-Julian requested a review from sonnyp February 21, 2024 14:05
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh thanks

I should drop that dependency eventually

@sonnyp sonnyp merged commit c4da728 into main Feb 21, 2024
@sonnyp sonnyp deleted the contributing branch February 21, 2024 17:09
@Hofer-Julian
Copy link
Contributor Author

huh thanks

I should drop that dependency eventually

The behavior is a bit weird.

It complains that there's no binary available and falls back to compiling.

Hofer-Julian added a commit that referenced this pull request Mar 24, 2024
`libxmljs` one of our nodejs dependencies requires a C++ compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants